activemodel: add ActiveModel::Error in 7.0

[aki19035vc]

Background

ActiveModel::Error was added in 6.1. However, 7.0 types have not kept up with this change because it use types created from 6.0 source code.

• 6.0: https://github.com/rails/rails/blob/v6.1.7.8/activemodel/lib/active_model/errors.rb
• 7.0: https://github.com/rails/rails/blob/v7.0.8.4/activemodel/lib/active_model/errors.rb

Solution

• Move existing ActiveModel::Errors type definitions to activemodel-6.0.rbs
• Generate a new prototype from the 7.0 source code and write it in activemodel-7.0.rbs

Remarks

• If this PR is accepted, I will add the more types to ActiveModel::Errors and ActiveModel::Error.
• I separated test by module, because I may want to distinguish it from Dirty, Callbacks, etc.

[github-actions[bot]]

@aki19035vc Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

• /merge: Merge this PR if CI passes

---

activemodel

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@hibariya, @ksss, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here.

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.

[ksss]

@aki19035vc Thank you for your contributing. But, the difference was too large for me to understand the purpose of the changes.

ActiveModel::Error was added in 6.1.

• Why is a change needed for 6.0?
• Why are there no changes for 6.1?

[aki19035vc]

@ksss

Thanks for the reply! I did not describe it well enough.

Why is a change needed for 6.0?

This is because the files in the activemodel/7.0 directory are symbolic links to the 6.0 files, as shown below.

• activemodel/7.0/activemodel-generated.rbs -> activemodel/6.0/activemodel-generated.rbs
• activemodel/7.0/activemodel.rbs -> activemodel/6.0/activemodel.rbs
• activemodel/7.0/patch.rbs -> activemodel/6.0/patch.rbs

So, I think it necessary to escape the existing definitions into activemodel-6.0.rbs, if I want to reflect changes after 6.1.

Why are there no changes for 6.1?

Because the 6.1 directory does not exist.

After creating a new directory for 6.1 and placing the files as follows,

• activemodel/6.1/activemodel-generated.rbs -> activemodel/6.0/activemodel-generated.rbs
• activemodel/6.1/activemodel.rbs -> activemodel/6.0/activemodel.rbs
• activemodel/6.1/patch.rbs -> activemodel/6.0/patch.rbs

Should I put ActiveModel::Errors and ActiveModel::Error types in the respective files below?

• activemodel/6.1/activemodel-6.1.rbs
• activemodel/7.0/activemodel-7.0.rbs

[ksss]

@aki19035vc OK, make sense.

Whether you do or not, we should make 6.1. Without 6.1, users using 6.1 will not be able to use ActiveModel::Error.

However, I am not satisfied with the current method using symbolic links. This system tends to result in frequent file movement, which increases the review burden. I will bring this up as a topic in the next core team meeting.

Until then, please wait a bit. Alternatively, please narrow the scope of this PR a bit more.

[aki19035vc]

@ksss OK! In this PR, I will not change the existing definitions, and just add the ActiveModel::Error type to activemodel-7.0.rbs. I will further reduce the scope of this PR by not supporting 6.1.

[aki19035vc]

@ksss I did not use rbs prototype and manually added the type to the public API.

ref:

• https://api.rubyonrails.org/v7.0.8.4/classes/ActiveModel/Error.html
• https://github.com/rails/rails/blob/v7.0.8.4/activemodel/lib/active_model/error.rb

Please review when you are free.

[github-actions[bot]]

Thanks for your review, @ksss!

@aki19035vc, @ksss This PR is ready to be merged. Just comment /merge to merge this PR.

[aki19035vc]

/merge