debug icon indicating copy to clipboard operation
debug copied to clipboard

Support XDG directories for config and history files

Open jgarber623 opened this issue 1 year ago • 2 comments

Description

Addresses #1031 by implementing support for XDG directories in accordance with the rules discussed in the issue and summarized in my comment here.

This change should be non-breaking in that the code continues to prefer existing default configuration files at ~/.rdbgrc and ~/.rdbg_history.

If those files do not exist and XDG environment variables are configured, then configuration and history files in the relevant XDG directories are used.

  • $XDG_CONFIG_HOME/rdbg/config (if file is present)
  • $XDG_DATA_HOME/rdbg/history

Note that $XDG_CONFIG_HOME is typically $HOME/.config and that $XDG_DATA_HOME is typically $HOME/.local/share. These are customizable by users, but I believe those are the customary/default paths.

jgarber623 avatar Dec 31 '23 03:12 jgarber623

Launchable Report

:x: Test session #2769253 failedos:ubuntu-latest test_task:test_consoledetails on CI
:bell: no issues :heavy_multiplication_x:118 tests failed :heavy_check_mark:179 tests passed

:x: Test session #2769258 failedos:ubuntu-latest test_task:test_consoledetails on CI
:bell: no issues :heavy_multiplication_x:121 tests failed :heavy_check_mark:176 tests passed

:x: Test session #2769260 failedos:ubuntu-latest test_task:test_consoledetails on CI
:bell: no issues :heavy_multiplication_x:118 tests failed :heavy_check_mark:179 tests passed

Passed test sessions

:white_check_mark: Test session #2769168 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2769169 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2769171 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2769172 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2769176 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2769180 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2769182 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2769183 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2769184 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2769185 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2769186 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2769189 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2769201 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2769215 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2769220 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2769222 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2769223 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2769224 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2769240 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2769257 passed os:ubuntu-latest test_task:test_consoledetails on CI

Build: refs_pull_1055_merge_55f66240abf152a91a42df8aa4d05e2a25387bdd

launchable-app[bot] avatar Mar 29 '24 08:03 launchable-app[bot]

Hello! I don't have the ability to re-run the failed checks and it's not immediately clear to me why those failed (and why Ruby 3.2 and 3.3 passed).

For someone more knowledgeable, do those failures look to be caused by changes in this pull request? Should I update this branch with a merge commit and have someone re-run the test suite?

jgarber623 avatar May 30 '24 13:05 jgarber623