csv icon indicating copy to clipboard operation
csv copied to clipboard

Recipes not copied downstream

Open BurdetteLamar opened this issue 2 years ago • 6 comments

A while back, I wrote a bunch of recipes for CSV. I don't think they're being copied downstream to ruby/ruby. I don't know how to fix that.

BurdetteLamar avatar Jun 28 '23 18:06 BurdetteLamar

It's a manual operation. We use https://github.com/ruby/ruby/blob/master/tool/sync_default_gems.rb for it. We run it when new major Ruby version is released or we want to do.

e.g.:

  • https://github.com/ruby/ruby/pull/5336
  • https://github.com/ruby/ruby/pull/7851

If you want changes only in ruby/csv soon, I can do it.

kou avatar Jun 29 '23 03:06 kou

I'm not sure I understand the issue here. What I think has happened is that the RDoc containing the link to the recipes was copied downstream, but the RDoc containing the recipes themselves was not copied. Is there something in the gemspec that specifieis what is to be copied?

BurdetteLamar avatar Jun 29 '23 21:06 BurdetteLamar

the RDoc

What does it refer? A documentation that you generated by RDoc from ruby/ruby?

kou avatar Jun 30 '23 06:06 kou

All I know is that the first link in https://docs.ruby-lang.org/en/master/CSV.html is broken, and I don't know how to fix it.

BurdetteLamar avatar Jun 30 '23 11:06 BurdetteLamar

@hsbt Do you know how we build https://docs.ruby-lang.org/en/master ?

kou avatar Jun 30 '23 21:06 kou

We built RDoc html with https://github.com/ruby/docs.ruby-lang.org/blob/master/Rakefile#L47

hsbt avatar Jul 03 '23 10:07 hsbt