Rubocop update - Not to be merged - Just for discussion

[abinoam]

Related to #42

[rubydesign]

Well, what can i say. Thanks for the effort, but mostly , ahem, sorry.

I stopped using rubocop at some point when codeclimate introduced reek. As you can see the .codeclimate has a line with rubocop: false. I should have taken the .rubocop away, sorry

You are right, it was getting to much to update it by hand. But it did complain a lot about some coding patterns that i was intentionally using (mostly visitor patter in the compilers)

We can still talk, but as you say, this will not be merged. If you want to make a PR with removing the .rubocop i'll accept that, and also any improvements on docs , or test docs. By the nature of time, i have difficulties taking a newbie perspective after 5 years, and would be happy for outside feedback on how approachable rubyx is.

[abinoam]

You are right, it was getting to much to update it by hand. But it did complain a lot about some coding patterns that i was intentionally using (mostly visitor patter in the compilers)

This is a common problem in using Rubocop. I solved it in HighLIne by using an auto generated .rubocop_todo.yml that immediately silenced all warnings in current code. (this PR does this) Then I have setup pronto gem to alert me of any regression between each PR (pronto apply Rubocop at patch only). So I could just forget about past style offenses and concentrate in doing the main job (coding). Then I slowly made the manual adjustments to Rubocop config to accept my common offenses or fixed the offending code.

https://github.com/JEG2/highline/blob/master/Gemfile

i have difficulties taking a newbie perspective after 5 years, and would be happy for outside feedback on how approachable rubyx is.

I can surely give you a completely newbie fresh eye perspective on Rubyx 😬😄 Trust me! I'll try to make everything work and tell what were my main difficulties as a newcomer in this realm of systems programming (compiling, etc). And... of course, a PR at the docs to easy things to the ones to come after me.

A harder goal would be to try make theses kind of dependency handling more automatic. (I don't know if it is possible).