shoryuken icon indicating copy to clipboard operation
shoryuken copied to clipboard

Scope the shoryuken context to the current fiber.

Open ioquatix opened this issue 11 months ago • 4 comments

I'd like to start a discussion about how to more efficiently manage the context during logging.

This exposes a proper interface for getting the current context.

In addition, I'd like to understand, do you expect if someone creates child fibers or threads, that the context should be shared? e.g. map-reduce / fan-out style workloads. I'm assuming the answer should be yes, but I'd like to know your opinion. In that case, it's better to use Fiber#storage.

ioquatix avatar Mar 06 '24 02:03 ioquatix

This PR is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

github-actions[bot] avatar May 06 '24 01:05 github-actions[bot]

@phstc do you have time to review? Thanks!

ioquatix avatar May 06 '24 21:05 ioquatix

Hi @ioquatix

Sorry, I'm a bit out of the loop here. Are there any breaking changes here?

I'd like to start a discussion about how to more efficiently manage the context during logging.

Asking in case this is good to go as a patch version or if there is any concern with a specific version of Ruby or Rails.

phstc avatar May 07 '24 00:05 phstc

In general, I don't believe this is a breaking change.

ioquatix avatar May 07 '24 03:05 ioquatix

This PR is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

github-actions[bot] avatar Jul 07 '24 01:07 github-actions[bot]

This PR was closed because it hasn't seen activity for a while.

github-actions[bot] avatar Jul 14 '24 01:07 github-actions[bot]

@phstc any update?

ioquatix avatar Jul 14 '24 03:07 ioquatix

@ioquatix, Unfortunately, I'm not currently active with Ruby or Shoryuken. I'm mainly merging maintenance pull requests.

It would be nice to have input from an active user.

Can you try the Slack channel? https://join.slack.com/t/shoryuken/shared_invite/zt-19xjq3iqc-KmoJ6eU6~qvZNqcLzIrjww

phstc avatar Jul 22 '24 16:07 phstc