shoryuken icon indicating copy to clipboard operation
shoryuken copied to clipboard

Support for ActiveJob.perform_all_later (Rails 7.1)

Open gondalez opened this issue 1 year ago • 3 comments

Hi,

Thanks for the handy gem 😌 🙏 We have been using it for ActiveJob mainly and it has been useful for our production workload.

I stumbled on ActiveJob.perform_all_later that was added in rails 7.1.

Are there any plans to support it in shoryuken? We have our own janky implementation of batch enqueueing that we would love to remove, should it become an implementation detail of shoryuken 😌

Specifically to support creating many sqs message in a single SendMessageBatch for increased throughput.

The rails PR for reference: https://github.com/rails/rails/pull/46603

There is an existing old closed issue, #710, but per this comment, it predates rails 7.1 which lead to it being closed.

I figured I'd open a new issue for clarity and extra visibility.

gondalez avatar Jan 30 '24 02:01 gondalez

Hi @gondalez

Thank you for the kind words!

There's no work being done related to that. All current improvements are individual-driven.

Are you interested in submitting a PR?

phstc avatar Jan 31 '24 04:01 phstc

@phstc no worries, I totally understand 👍

I don't have any spare time to do the change at the moment. But if you're happy to I think it'd be good to leave the issue open in case some kind traveller wants to have a try? :)

I figure this issue is also handy as a "not yet supported" doc for anyone searching.

gondalez avatar Jan 31 '24 04:01 gondalez

@gondalez all good. The issues get auto-closed after some time.

phstc avatar Jan 31 '24 05:01 phstc

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

github-actions[bot] avatar Apr 01 '24 01:04 github-actions[bot]

This issue was closed because it hasn't seen activity for a while.

github-actions[bot] avatar Apr 09 '24 01:04 github-actions[bot]