hyper-mesh

hyper-mesh copied to clipboard

When an anonymous create fails the object isn't destroyed, so the next time you create a record it actually tries to create two. I noticed this as I had a...

sfcgeorge

Add has_and_belongs_to_many via has_many :through

1

This code implements `has_and_belongs_to_many` in Hyperloop by using the existing `has_many :through` functionality and dynamically generating the join table. ```ruby if RUBY_ENGINE == "opal" module ActiveRecord module ClassMethods def has_and_belongs_to_many(assoc,...

sfcgeorge

should improve performance

catmando

Security hole - it might be possible to get a list of all id's for a model

7

this https://github.com/ruby-hyperloop/hyper-mesh/blob/ebf661eecc592799b7723bb666c1d42d84551918/lib/reactive_record/server_data_cache.rb#L182 reads every id, but is not protected by the `check_permission_with_acting_user` method it should read: ```ruby collection = cache_item.value.collect do |record| record.check_permission_with_acting_user(@acting_user, :view_permitted?, :id) record.id end cache_item.build_new_cache_item(collection, method, method)...

catmando

add exists? method

3

Proof of concept below. ```ruby class ApplicationRecord < ActiveRecord::Base self.abstract_class = true def self.exists?(*args) HyperMeshExists.run(model: name, args: args) end if RUBY_ENGINE == 'opal' class HyperMeshExists < Hyperloop::ServerOp param acting_user: nil,...

catmando

I have 2 components A and B. Both cause queries. When queries for component B are batched in with component A then the placeholder values in A are never resolved....

sfcgeorge

in development & test errors caused by failing operations should be meaningful

3

currently we don't give a lot of info back on failures when you do a `find` on a record that doesn't exist or when you don't have proper permissions. This...

catmando

hyper-mesh ignores associations for subclasses

1

When accessing associations on records that are subclassed, hyper-mesh only checks the associations on the records base_class ex code ```ruby class User < ActiveRecord::Base ... end class Administrator < User...

adamcreekroad

Basic specs dockerisation...

6

...specs are failing, unfortunately, locally (not for merge just yet, see comments).

costa

isomorphic active-record mode

3

There are many active-record methods that are not implemented in hyper-model. In some cases not having these methods can cause strange failures that are hard to diagnose. Instead we should...

catmando