grape icon indicating copy to clipboard operation
grape copied to clipboard

Added test for failing nested given validation

Open andreacfm opened this issue 6 years ago • 3 comments

Using nested given validations looks unsupported. This is just a simple test case to show the issue.

andreacfm avatar Oct 22 '18 22:10 andreacfm

1 Warning
:warning: Unless you’re refactoring existing code, please update CHANGELOG.md.
1 Message
:book: We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Here's an example of a CHANGELOG.md entry:

* [#1804](https://github.com/ruby-grape/grape/pull/1804): Added test for failing nested given validation - [@andreacfm](https://github.com/andreacfm).

Generated by :no_entry_sign: danger

grape-bot avatar Oct 22 '18 22:10 grape-bot

@darren987469 was just in this code in #1810, maybe interested in taking a look at this too?

dblock avatar Oct 31 '18 10:10 dblock

@dblock I will have a look. Thanks

andreacfm avatar Oct 31 '18 10:10 andreacfm

Look like can be closed :)

numbata avatar May 06 '24 12:05 numbata

Yep, closing with https://github.com/ruby-grape/grape/pull/1811.

dblock avatar May 07 '24 07:05 dblock