Change HTTP DELETE status code and body logic, use nil for HTTP 204

Open basjanssen opened this issue 7 years ago • 2 comments

This PR has two goals:

Change HTTP DELETE status code and body logic presenting {}. [], false will be regarded as content and will use HTTP status code 200. The content body will be presented with the set content.
Change using nil to set NO_CONTENT Using nil will be more consistent with the way the content is regarded in the previous point.

Fixes #1768

[x] Receive and process first round of feedback
[x] Need to fix the spec at spec/grape/dsl/inside_route_spec.rb:144 (I do not understand the reason of failure).

Jul 24 '18 23:07 basjanssen

definitely would need a good UPGRADING.md change to understand all that's changing and will take a look at the details in code, too.

@namusyaka would appreciate another pair of eyes

Jul 25 '18 18:07 dblock

Sorry this took so long. I have processed the feedback and updated the CHANGELOG and UPGRADING files. I love to receive feedback again :)

Oct 18 '18 08:10 basjanssen