grape-swagger icon indicating copy to clipboard operation
grape-swagger copied to clipboard

Allow range be Float

Open artyomb opened this issue 2 years ago • 6 comments

https://github.com/ruby-grape/grape-swagger/issues/904#issue-1881746890

As described in https://docs.swagger.io/spec.html

minimum | string | number, integer | The minimum valid value for the type, inclusive. If this field is used in conjunction with the defaultValue field, then the default value MUST be higher than or equal to this value. The value type is string and should represent the minimum numeric value. Note: This will change to a numeric value in the future.

The values may be number (float or double)?

artyomb avatar Sep 05 '23 11:09 artyomb

@artyomb … yeah, makes sense to allow any kind of number

please rebase against master, it fixes the rubocop stuff

LeFnord avatar Sep 06 '23 18:09 LeFnord

Sorry, if I broke something. I don't know how to rebase with this pull request.

artyomb avatar Sep 06 '23 21:09 artyomb

I did "sync fork". Hope it helped?

artyomb avatar Sep 18 '23 09:09 artyomb

no … please have a look on the failures, it seems your change is related to it

LeFnord avatar Nov 13 '23 18:11 LeFnord

Ok, sorry. I don't know how complete the request. Please close/reject it. Maybe move to the issues.

artyomb avatar Nov 13 '23 20:11 artyomb