grape-swagger icon indicating copy to clipboard operation
grape-swagger copied to clipboard

Published 20 hours ago • verified publisher icon ruby-grape

Fixes (restores) route ordering

Open dchandekstark opened this issue 2 years ago • 2 comments

This restores the route ordering which was changed in #631.

Fixes #679

dchandekstark avatar Apr 22 '22 16:04 dchandekstark

I have one failing test, but I have to wonder if it's due to a bug in grape. The purported solution in #631 may have simply masked the problem. If in fact the issue is with grape-swagger I don't think the appropriate solution is to simply reverse the order of the route set. In any event, the test case seems to me rather odd. I couldn't find anything quite like it in grape's docs or specs (ofc I could well have missed it).

dchandekstark avatar Apr 22 '22 18:04 dchandekstark

Please note that this change may reintroduce the issue that #631 attempted to solved, albeit IMO incorrectly.

dchandekstark avatar Apr 23 '22 22:04 dchandekstark

I know that I have dodged a problem by removing a test (and I haven't yet tried adding it back), but this route ordering problem still exists. I love this project, and I'd like to help fix this. I have merged in the latest changes and all other tests are passing.

dchandekstark avatar Feb 15 '24 13:02 dchandekstark

thanks for finishing it ok will merge it, will see if the ordering discussion pops up again ;)

LeFnord avatar Mar 03 '24 15:03 LeFnord