Fully Support Styles

Open rickychilcott opened this issue 2 years ago • 5 comments

Implement creating, removing, and editing existing document styles.

It's a massive PR. Sorry.

But it works and it's cool. So it's got that going for it.

Dec 01 '23 18:12 rickychilcott

Are we still trying to support Ruby 2.6 @satoryu? Thanks for reviewing and considering this change.

Dec 02 '23 19:12 rickychilcott

@rickychilcott, thank you for opening this pull request! As you pointed out, support for Ruby 2.6 should be dropped. I will take care of it, so please disregard the failure on Ruby 2.6 at the moment.

Dec 04 '23 11:12 satoryu

FYI: #146

Dec 04 '23 11:12 satoryu

Cool, thanks! I merged in master and added a bit more documentation!

Dec 04 '23 16:12 rickychilcott

Hey @satoryu! We've now shipped a feature in our application using my fork, and it's working like a charm. Are you willing to review this to see if we could consider getting this merged in?

Dec 11 '23 16:12 rickychilcott