rubrik-sdk-for-python icon indicating copy to clipboard operation
rubrik-sdk-for-python copied to clipboard

An update_sla() function

Open kambleakash0 opened this issue 2 years ago • 0 comments

Description

Wrote an update_sla() function based on the issue #250 Since CDM versions after 5.1 all have put the patch call for modifying SLA details in the V3, I have used the same call for those versions and versions for prior to 5.2 I have used the V1 put call to modify SLA parameters.

Related Issue

create update_sla() function to allow changing settings of an existing SLA #250

Motivation and Context

Provides a handy function call to users in case they want to modify an already created SLA.

How Has This Been Tested?

Tried to manually test it on a Rubrik cluster with CDM version 8.0.1-21908 but facing some issue. Maybe due to V3 not being one of the valid API versions but facing the same issue even after I added 'v3' to the 'valid_api_versions' list inside '_api_validation()' from 'rubrik_cdm.py.Connect' class: valid_api_versions = ['v1', 'v2', 'internal', 'v3']

Screenshot of the issue faced:

Screenshot 2022-09-09 214054

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTION document.
  • [ ] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

kambleakash0 avatar Sep 09 '22 16:09 kambleakash0