rubrik-modules-for-ansible
rubrik-modules-for-ansible copied to clipboard
Replication target private
Description
Please describe your pull request in detail.
Create module to set replication target using private network.
Related Issue
This project only accepts pull requests related to open issues.
- If suggesting a new feature or change, please discuss it in an issue first.
- If fixing a bug, there should be an issue describing it with steps to reproduce
Please link to the issue here #105
Motivation and Context
Why is this change required? What problem does it solve?
- Moves the need for direct API payload to an actual module
- Creates idempotent tests inside the module reducing number of ansible tasks in config mgmt
- Brings project closer to API coverage
How Has This Been Tested?
- Please describe in detail how you tested your changes.
- Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. Ansible 2.9.8 RHEL 7.8 Rubrik CDM Virtual Edge Appliance 5.0.2
No idempotent unit tests have been built for this module since I'm unsure how to build it (api calls to 2 different hosts).
Screenshots (if appropriate):
Setting without force
option with target already set:
Using force
option on node with target already set:
Unit Tests:
Types of changes
What types of changes does your code introduce? Put an x
in all the boxes that apply:
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
Go over all the following points, and put an x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!
- [X] My code follows the code style of this project.
- [X] My change requires a change to the documentation.
- [X] I have updated the documentation accordingly.
- [X] I have read the CONTRIBUTION document.
- [ ] I have updated the CHANGELOG file accordingly for the version that this merge modifies.
- [X] I have added tests to cover my changes.
- [X] All new and existing tests passed.