RSpec/HookArgument: Adding an EnforcedStyle of :all & accept both :each and :all as EnforcedStyle?

[nc-nystromb]

I am working in a huge codebase that has a pattern of using before...do syntax and it resulted in really slow test runs because a lot of setup is happening before each test.

I would like to propose to add an all option and also the possibility accept both each and all as an enforced style. Basically, I want to enforce not using before...do in favor of either each or all. I really just want developers in our codebase to be explicit about their before/after hooks.

What do you all think about this idea? Does this make sense to make a PR on the RSpec/HookArgument cop or should I make something custom just for my project? I'm not sure if this would be useful for others.

Thanks for your consideration

[pirj]

:example/:context are two that are recommended. There is no strong recommendation not to use :example as a hook scope.

Are you up to update the cop to provide this flexibility?

[nystromb]

I think I can try making a pull request. Just so the requirements are clear, would the flexibility would be to add an explicit option to the EnforcedStyle, so that you won't be able to just write before do without an argument? There appears to already be an implicit, each, and example as options.

[pirj]

This sounds right.

[Darhazer]

Generally, if you configure with enforced style :each (or :example for that matter), you won't be able to leave before without specifying the scope. It will still allow before(:all). So the only thing an explicit option will do is to allow either example or each to be used.