rubocop-rspec icon indicating copy to clipboard operation
rubocop-rspec copied to clipboard

Published 20 hours ago • verified publisher icon rubocop

Reduce false positives of ExampleLength when using #expect_offense et. al.

Open Drenmi opened this issue 7 years ago • 2 comments

We currently have over 3,000 violations over in the core repo. Mostly because this cop doesn't care about our internal DSLs. 🙂

One approach to fixing this could be counting heredocs as a single line. WDYT?

Drenmi avatar Jun 19 '18 20:06 Drenmi

Related to #249

Darhazer avatar Jun 20 '18 14:06 Darhazer

Mostly because this cop doesn't care about our internal DSLs. 🙂

“Our” as in “RuboCop’s’? If that’s the case, perhaps the cop should just be disabled on RuboCop?

Disclaimer: I prefer disabling all *-length cops on the projects I’m working on. Adding 1 line to a method/class/block and then getting a violation error feels counter-productive.</rant>

bquorning avatar Jun 21 '18 07:06 bquorning