rubocop-minitest
rubocop-minitest copied to clipboard
[Fix #152] Add `AdditionalMethods` configuration to `Minitest/GlobalExpectations`
Closes #152
Before submitting the PR make sure the following are checked:
- [x] Wrote good commit messages.
- [x] Commit message starts with
[Fix #issue-number]
(if the related issue exists). - [x] Feature branch is up-to-date with
master
(if not - rebase it). - [x] Squashed related commits together.
- [x] Added tests.
- [x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
- [x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
- [x] Run
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.
@koic can you review this please?
Can you update the parameter name to ExtensionMatchers
and mention it in the documentation text?
@koic Changed to ExtensionMatchers
.
@koic ping
Hm, the approach we should take will depend on what the custom matchers are like. I've asked the issue author @gi the use case. Let's wait for a reply. https://github.com/rubocop/rubocop-minitest/issues/152#issuecomment-997421408
I'm going to close this PR because no response for a long time from #152. Flexibility without really necessary extensibility introduces unnecessary complexity at the cost of simplicity.