rubocop-minitest icon indicating copy to clipboard operation
rubocop-minitest copied to clipboard

[Fix #152] Add `AdditionalMethods` configuration to `Minitest/GlobalExpectations`

Open tejasbubane opened this issue 2 years ago • 5 comments

Closes #152


Before submitting the PR make sure the following are checked:

  • [x] Wrote good commit messages.
  • [x] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • [x] Feature branch is up-to-date with master (if not - rebase it).
  • [x] Squashed related commits together.
  • [x] Added tests.
  • [x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • [x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • [x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

tejasbubane avatar Nov 05 '21 18:11 tejasbubane

@koic can you review this please?

tejasbubane avatar Dec 06 '21 19:12 tejasbubane

Can you update the parameter name to ExtensionMatchers and mention it in the documentation text?

koic avatar Dec 08 '21 06:12 koic

@koic Changed to ExtensionMatchers.

tejasbubane avatar Dec 08 '21 19:12 tejasbubane

@koic ping

tejasbubane avatar Dec 18 '21 14:12 tejasbubane

Hm, the approach we should take will depend on what the custom matchers are like. I've asked the issue author @gi the use case. Let's wait for a reply. https://github.com/rubocop/rubocop-minitest/issues/152#issuecomment-997421408

koic avatar Dec 19 '21 16:12 koic