rubocop-factory_bot
rubocop-factory_bot copied to clipboard
Disable `ConsistentParenthesesStyle` by default: redundant with `Style/` config
This is marked as a 'pending' rule, so I'm not 100% this will be enabled by default, but that seems to be the case more often than not with rubocop plugins.
Unless I'm missing some gotcha, FactoryBot method calls are... just method calls! I would prefer letting the base Rubocop configuration govern the styles for ALL method calls. The methods can be used in many different contexts, as illustrated by #84 and #15 . I think the most reasonable default is to not enforce parens vs. no-parens.
Enforcing one style by default also increases the pain of installing the gem in an existing project. I recently added rubocop-factory_bot to a project, and this was the only rule that needed configuration. Otherwise I'm very happy with the experience, it was worth it!
I appreciate that some people want to treat these methods one way or the other consistently. I just think the rule should be opt-in.