rubocop-emacs icon indicating copy to clipboard operation
rubocop-emacs copied to clipboard

Rubocop config file now includes in execution

Open jherrlin opened this issue 7 years ago • 4 comments

This will look for a config file in the project root and include it in the execution if found.

jherrlin avatar Feb 25 '18 18:02 jherrlin

Is there any reason why this request doesn't get merged? Is it related to the naming of the rules file mentioned by @bbatsov ?

MoskitoHero avatar Oct 29 '18 05:10 MoskitoHero

Yep.

bbatsov avatar Oct 29 '18 06:10 bbatsov

There's also the fact that RuboCop would normally pick up the right configuration file anyways, as we're running it after cding to the appropriate directory. Generally I'm not quite certain what this PR was supposed to fix.

bbatsov avatar Oct 29 '18 06:10 bbatsov

Guess that I didn't know that RuboCop picked up the configuration file or if I could not spell the config file name, dont remember. Should I close the PR?

jherrlin avatar Oct 29 '18 07:10 jherrlin