rubocop-capybara icon indicating copy to clipboard operation
rubocop-capybara copied to clipboard

Move the department associated with `Capybara::RSpecMatchers` to `Capybara/RSpec/*`

Open ydah opened this issue 1 year ago • 2 comments

This PR move the department associated with Capybara::RSpecMatchers to Capybara/RSpec/*.

Capybara/CurrentPathExpectation, Capybara/SpecificMatcher, Capybara/NegationMatcher, and Capybara/VisibilityMatcher cops depend on methods from the Capybara::RSpecMatchers class.

https://www.rubydoc.info/gems/capybara/Capybara/RSpecMatchers

This is breaking changes and will be planned during the major upgrade to RuboCop Capybara3.0.


Before submitting the PR make sure the following are checked:

  • [ ] Feature branch is up-to-date with main (if not - rebase it).
  • [ ] Squashed related commits together.
  • [ ] Added tests.
  • [ ] Updated documentation.
  • [ ] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • [ ] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • [ ] Added the new cop to config/default.yml.
  • [ ] The cop is configured as Enabled: pending in config/default.yml.
  • [ ] The cop documents examples of good and bad code.
  • [ ] The tests assert both that bad code is reported and that good code is not reported.
  • [ ] Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • [ ] Set VersionChanged: "<<next>>" in config/default.yml.

ydah avatar Mar 22 '24 18:03 ydah

1 Warning
:warning: There is a cop that became Enabled: true due to this pull request.
Please review the diff and make sure there are no issues.

Generated by :no_entry_sign: Danger

github-actions[bot] avatar Mar 22 '24 18:03 github-actions[bot]

After two years, a whole hundred PRs, I believe it’s a good moment for a major release! 🙌

pirj avatar Jan 09 '25 11:01 pirj