rubocop-capybara
rubocop-capybara copied to clipboard
Move the department associated with `Capybara::RSpecMatchers` to `Capybara/RSpec/*`
This PR move the department associated with Capybara::RSpecMatchers to Capybara/RSpec/*.
Capybara/CurrentPathExpectation, Capybara/SpecificMatcher, Capybara/NegationMatcher, and Capybara/VisibilityMatcher cops depend on methods from the Capybara::RSpecMatchers class.
https://www.rubydoc.info/gems/capybara/Capybara/RSpecMatchers
This is breaking changes and will be planned during the major upgrade to RuboCop Capybara3.0.
Before submitting the PR make sure the following are checked:
- [ ] Feature branch is up-to-date with
main(if not - rebase it). - [ ] Squashed related commits together.
- [ ] Added tests.
- [ ] Updated documentation.
- [ ] Added an entry to the
CHANGELOG.mdif the new code introduces user-observable changes. - [ ] The build (
bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).
If you have created a new cop:
- [ ] Added the new cop to
config/default.yml. - [ ] The cop is configured as
Enabled: pendinginconfig/default.yml. - [ ] The cop documents examples of good and bad code.
- [ ] The tests assert both that bad code is reported and that good code is not reported.
- [ ] Set
VersionAdded: "<<next>>"indefault/config.yml.
If you have modified an existing cop's configuration options:
- [ ] Set
VersionChanged: "<<next>>"inconfig/default.yml.
| 1 Warning | |
|---|---|
| :warning: | There is a cop that became Enabled: true due to this pull request.Please review the diff and make sure there are no issues. |
Generated by :no_entry_sign: Danger
After two years, a whole hundred PRs, I believe it’s a good moment for a major release! 🙌