Fawn
Fawn
I fully agree with @bratpeki's assessment: > I still feel as if this is just too much work for too little reap. You make one MIDI clip with those notes...
> WHOAH YOU ACTUALLY FOUND IT?! Congratulations, I could not figure it out!!! 🎉 I briefly tested it, and it's definitely fixed! Hmmm, in the images you shared I am...
I've updated this so it no longer uses the evil hack. Now the other tabs actually have their width restricted by the instrument tab.
I've also made some more changes, so this resolves #7876 as well now. **Edit:** #8096 happens to resolve #7876, so I'll revert my changes here and let that other PR...
> I'm not quite sure of the advantage of having both "mod" and "mod max" controls. They're functionally identical, their values just being multiplied together. Is this a common thing...
The frequency multiplication happens in the waveform generation function, so the phase is automatically reset as part of that.
> @iansannar Do you want to add something more here? Or, can I start review? It is usable in its current form, so you can go ahead and review it....
https://github.com/LMMS/lmms/issues/5592 ~~This PR needs review but is otherwise ready.~~ - [ ] Style Review: In progress - [ ] Code Review: In progress - [ ] Testing: ~~Tested by a...
Pretty sure it's just waiting for @PhysSong to review both code and style.
Ah. I have no idea how I did that, but clearly I didn't rebase properly and now the commit history is duplicated 😓 Anyways, after re-examining this, it's clear that...