grunt-git icon indicating copy to clipboard operation
grunt-git copied to clipboard

Readme: gitcheckout command options parameter misspelling

Open dmytro-shchurov opened this issue 11 years ago • 0 comments

https://github.com/rubenv/grunt-git#optionscreate-1 The second options.create parameter must be named somehow else.

dmytro-shchurov avatar Dec 30 '14 10:12 dmytro-shchurov

You probably just need to set up the V8 context.

Take a look at the beginning of V8Runner_runJS in jv8.cpp to see how to do this. It's fairly complicated; you'll probably need to add a handle for the C++ V8Runner associated with the V8Function.

namuol avatar Jul 11 '13 20:07 namuol

Any updates regarding this issue?

TacB0sS avatar Jul 24 '13 14:07 TacB0sS

It's fixed in the Expensify repo: https://github.com/Expensify/jv8/commit/0f7c48ef8b551d35dd37ca3f647a7657ad2bf2ee.

@namuol Should we PR in your repo? We've come to a stable version but we break the current API (native cast).

ldiqual avatar Jul 24 '13 20:07 ldiqual

Hey sorry, I thought I replied to this last week. -_- Yes! The current API isn't even properly versioned yet, so it's totally okay to break! I'll probably add a VERSION file soon that contains 0.0.1-prealpha. ;)

namuol avatar Jul 28 '13 08:07 namuol

is there a chance we see a new nightly android build? or should i build my own version?

dmengelt avatar May 05 '14 10:05 dmengelt