angular-gettext-tools icon indicating copy to clipboard operation
angular-gettext-tools copied to clipboard

fix: update jshint exception switch to current jshint version

Open clue42 opened this issue 9 years ago • 6 comments

update the jshint exception switch to current (2.6.0) version for mixed quotation marks. As of jshint > 1.0 this exception is W110 instead of the used W100

clue42 avatar Feb 20 '15 15:02 clue42

How was this working before?

rubenv avatar Feb 20 '15 15:02 rubenv

Jshint was throwing warnings and if you do have quite a few translations, linting your source got pretty annoying.

clue42 avatar Feb 20 '15 15:02 clue42

Ah yes. Well, I stand by my point that you should ignore generated files from linting.

This might happen again and it's totally pointless. Just don't lint machine-generated stuff, it's a waste of time.

rubenv avatar Feb 20 '15 15:02 rubenv

Well, I stumbled across this as where were some exception switches in the code, however just old ones.

clue42 avatar Feb 20 '15 15:02 clue42

If we already add a JSHint directive to the generated JS, I suppose we should at least use the right directive :-)

But honestly, I would vote for not outputting any JSHint directives. Or maybe jshint:ignore

gabegorelick avatar Mar 05 '15 20:03 gabegorelick

completely disabling jshint on the compiled file is the right choice, as one does not have influence on the global jshint settings of the developer and also one can't influence the generated code.

tylkomat avatar Mar 31 '16 09:03 tylkomat