angular-debounce
angular-debounce copied to clipboard
Make compatible with webpack 2
When using angular-debounce with the changes in this pull request, when used with webpack, there's an error when running the angular app.
Uncaught Error: [$injector:modulerr] Failed to instantiate module nprc-portal due to:
Error: [$injector:modulerr] Failed to instantiate module {} due to:
Error: [ng:areq] Argument 'module' is not a function, got Object
...
See the changes in README.md how I'm using angular-debounce and how it can be used with the changes in this PR
Tests are failing, but I tested locally and they're failed without the changes in this PR too. @rubenv Wanna have look?
I have no clue why this test suddenly fails. All is green when looking at the build history (https://travis-ci.org/rubenv/angular-debounce/builds), but when I try a clean git checkout locally, it does indeed fail.
Something must've changed within Angular?
I use angular-debounce as a dependency to an AngularJS 1.x project that I'm upgrading to use webpack, npm, es6 instead of grunt, bower and es5. Angular-debounce is one of the many dependencies that didn't play nice with webpack. There's to much work for me right now to help you figure out the problems with the tests. But maybe you can test it manually and merge anyway.