Ruben Taelman

Results 935 comments of Ruben Taelman

See #1040 for more details on browser tests.

Thanks for the PR @MPParsley! It looks like the Docker build is failing though. Probably because `/var/www/` is owned by the root?

Sure, the home folder is ok! But it looks like the build still fails with that change. (I haven't used the `USER` functionality of Docker before, so not sure what...

Ouch, created https://github.com/comunica/comunica/issues/947 for this. Restarted the job.

> Instead of creating our own user we can/should reuse the default node user. Sure, that sounds reasonable to me.

Done. (locally building the Dockerfile might be easier though)

Really nice work @MPParsley, thanks!

We already have a callback to only generate data if a logger is active: https://github.com/comunica/comunica/blob/5b2dd7af8d6d5a546f3b7d92b5b374bb93ba374e/packages/core/lib/Actor.ts#L118-L123 However, what we don't have yet indeed, is a way to only generate data if...

https://github.com/comunica/manifest-ldf-tests/commit/964e8be9252a74be3a38446ef060b264e58c321b might fix the integration error, but not sure about the unit test error.

The fix for #950 may also be a fix for this. Let's wait a while to observe... Edit: Nope, still failing: https://github.com/comunica/comunica/runs/7091033456?check_suite_focus=true