sodiumpp icon indicating copy to clipboard operation
sodiumpp copied to clipboard

Boxer for secret sharedkey

Open tigusoft opened this issue 9 years ago • 2 comments

Boxer/unboxer can now work with a secret preshared key, instead of my privkey + his pubkey.

Done as other constructor.

Needed to move stuff to a base class so it's nicer, but it should be 0-overhead (base class doesn't have vtable).

tigusoft avatar Apr 27 '16 15:04 tigusoft

@rubendv thanks for wording corrections, will apply them soon.

About the TODO, it's for an issue we found, we're not yet fixing it and our code still does same mistake for now - #14

There is one important thing wrong in this PR we made: it does not make too much sense for unboxer to have default value of nonce_constant (the random nonce). We should I guess document that, or just remove the defaulted value.

tigusoft-vm avatar Apr 28 '16 10:04 tigusoft-vm

Okay, I'll wait for you to fix the default value and then it can be merged. Thanks for the PR!

rubendv avatar Apr 28 '16 13:04 rubendv