ssbu icon indicating copy to clipboard operation
ssbu copied to clipboard

ATK_HIT_ABS params missing accessor calls

Open buhao8 opened this issue 4 years ago • 0 comments

Currently, the last 3 parameters of ATK_HIT_ABS are displayed incorrectly (most notable occurrences are in throws).

Here's an example of it:

ATK_HIT_ABS(FIGHTER_ATTACK_ABSOLUTE_KIND_THROW,
            hash40("throw"),
            FIGHTER_STATUS_THROW_WORK_INT_TARGET_OBJECT,
            FIGHTER_STATUS_THROW_WORK_INT_TARGET_HIT_GROUP,
            FIGHTER_STATUS_THROW_WORK_INT_TARGET_HIT_NO)

The last 3 arguments should be passed through WorkModule::get_int64 like so:

ATK_HIT_ABS(FIGHTER_ATTACK_ABSOLUTE_KIND_THROW,
            hash40("throw"), 
            WorkModule::get_int64(module_accessor, FIGHTER_STATUS_THROW_WORK_INT_TARGET_OBJECT), 
            WorkModule::get_int64(module_accessor, FIGHTER_STATUS_THROW_WORK_INT_TARGET_HIT_GROUP), 
            WorkModule::get_int64(module_accessor, FIGHTER_STATUS_THROW_WORK_INT_TARGET_HIT_NO))

buhao8 avatar Aug 20 '20 16:08 buhao8