Rubberduck icon indicating copy to clipboard operation
Rubberduck copied to clipboard

Unused and Un-assigned UDT Member inspections

Open BZngr opened this issue 2 years ago • 1 comments

Version 2.5.2.x (debug) OS: Microsoft Windows NT 10.0.19044.0, x64 Host Product: Microsoft Office x64 Host Version: 16.0.15028.20228 Host Executable: EXCEL.EXE

Description RD does not flag unused or unassigned User Defined Type members.

To Reproduce The following code generates 'VariableNotUsed' and 'VariableNotAssigned' inspection results for mNotUsed, but no flagged results for the SecondVal UDT Member.

Option Explicit

Private Type TMCVE
    FirstVal As Long
    SecondVal As Double
End Type

Private this As TMCVE

Private mUsed As Long
Private mNotUsed As Double

Private Sub Class_Initialize()
    mUsed = 1
    this.FirstVal = 1
End Sub

Private Function Sum() As Long
    Sum = mUsed + this.FirstVal
End Function

Expected behavior In the above example, RD should flag SecondVal as UDTMemberNotUsed and UDTMemberNotAssigned (if implemented as a dedicated inspection) or flag SecondVal as part of the VariableNotUsed/Assigned inspection result sets.

BZngr avatar Apr 25 '22 10:04 BZngr

The part of the issue regarding the unused UDT member seems to be fixed already by the linked PR. Since there is currently no UDTMemberNotAssignedInspection I relabel this an enhancement.

MDoerner avatar Oct 07 '22 07:10 MDoerner