Roberto Tyley

Results 136 comments of Roberto Tyley

> works well at last. Thank you Great! What was the problem just before that (with https://github.com/rtyley/bfg-repo-cleaner/issues/58#issuecomment-59400581)? How did you fix it?

Just to offer an alternative, if you're on AWS you may want to consider `play-secret-rotation` as an alternative to putting secrets in production config: https://github.com/guardian/play-secret-rotation/blob/master/aws-parameterstore/README.md

> In my case the issue was that the default setting of `failoverTimeMillis`, which is 10 seconds, was too low for my application. This was a good fix for us....

Thanks for your response @bjrara ! If you have time, I'd be very grateful if you could review PR https://github.com/awslabs/amazon-kinesis-client/pull/848, as I believe it could be a good solution to...

I've rebased this PR on top of the latest `master` commit, resolving the merge conflict with https://github.com/awslabs/amazon-kinesis-client/pull/861, the PR that reverted https://github.com/awslabs/amazon-kinesis-client/pull/847 - and also fixed the embarrassing problem with...

I think I'm encountering this same issue, after applying https://github.com/guardian/scala-steward-public-repos/pull/3 I'm not seeing this expected line in the [logs](https://github.com/guardian/scala-steward-public-repos/runs/7359350622?check_suite_focus=true#step:3:1): https://github.com/scala-steward-org/scala-steward-action/blob/48b0a17dfcec3e15d15713a6a7303e250ede9e36/src/check.ts#L57

@johnduffell reported another occurrence of this issue - in this case, it seemed that Travis had forgotten that @prout-bot was a member of the @guardian GitHub organisation: ![image (4)](https://user-images.githubusercontent.com/52038/86129890-48c9a480-badb-11ea-8ec2-12bd413d1de8.png) Hitting...

Looks like #40 didn't fix this issue after all? It shouldn't have removed the `commercial` label here: ![image](https://cloud.githubusercontent.com/assets/52038/23455977/8f8f8ab0-fe69-11e6-9edf-bb0de4818c64.png) Seen at https://github.com/guardian/frontend/pull/15976#event-981558096

Damn, yep, this is definitely still happening :( ![image](https://user-images.githubusercontent.com/52038/39178978-047b9fcc-47ab-11e8-8ac8-6bf35a616b34.png) https://github.com/guardian/ophan/pull/2751#event-1586495804