rttr icon indicating copy to clipboard operation
rttr copied to clipboard

library_win crash

Open NikolaMr opened this issue 6 years ago • 2 comments

In the library_win.cpp file there is an error.

The line that is problematic is: prefix_list.insert(suffix_list.begin(), std::wstring()); It should be prefix_list.insert(prefix_listbegin(), std::wstring());

The wrong iterator is given to the insert method which causes the crash.

Best regards, Nikola

NikolaMr avatar May 13 '19 08:05 NikolaMr

I have a PR for this, but I would like to understand how this lead to a crash. What happens there exactly? #206

acki-m avatar May 21 '19 20:05 acki-m

The wrong iterator (suffix_list.begin()) is given to the prefix_list's insert method which causes the crash since prefix_list is trying to insert the item into the memory area of which he isn't the owner.

NikolaMr avatar May 22 '19 06:05 NikolaMr