rttr icon indicating copy to clipboard operation
rttr copied to clipboard

Published 20 hours ago • verified publisher icon rttrorg

Replace with std::string_view for C++17

Open gabyx opened this issue 5 years ago • 4 comments

gabyx avatar Jan 26 '19 17:01 gabyx

unknown warning group '-Wself-assign-overloaded', ignored I needed to disable this warning in the test: need to turn that on for clang greater then a specific version... for clang 7.0 it does not work.

gabyx avatar Jan 27 '19 11:01 gabyx

Coverage Status

Coverage decreased (-0.03%) to 92.254% when pulling d4f31cda70378240c43a2a9099516f9331bfd148 on gabyx:feature/remove-string-view into b3a131cf6a42c8bbcd7dd75c2acc9c61c0722775 on rttrorg:master.

coveralls avatar Jan 27 '19 14:01 coveralls

I included a cmake options USE_LATEST_STD which make the library if MAX_CXX_VERSION is >= 17 using std::string_view which adjusts the minimum version to 17.

gabyx avatar Jan 27 '19 14:01 gabyx

Oh, here ia the answer why RTTR uses own string_view. Any progress on this MR?

mapron avatar Jul 04 '20 08:07 mapron