Roman Tsisyk

Results 394 comments of Roman Tsisyk

> LGTM, @rtsisyk please merge if it works for you. I am waiting for the current release to finish.

``` #4 0x00000001032fb280 in BookmarkManager::GetBmCategory(unsigned long long) const at /Users/roman/code/organicmaps/organicmaps/map/bookmark_manager.hpp:586 #5 0x000000010330bbf8 in BookmarkManager::GetCategoryFileName(unsigned long long) const at /Users/roman/code/organicmaps/organicmaps/map/bookmark_manager.cpp:1548 #6 0x00000001032fffdc in BookmarkManager::GetMetadataEntryName(unsigned long long) const at /Users/roman/code/organicmaps/organicmaps/map/bookmark_manager.cpp:1808 #7 0x00000001032ffda0...

> Looks like https://developer.android.com/ndk/guides/gwp-asan can be enabled for OM to detect such issues. ASAN has been already enabled for the last 6 months (see https://github.com/organicmaps/organicmaps/pull/6634). This is how this buffer...

@Jean-BaptisteC thanks for the contribution!! It would be nice to match the sizes and resolutions of the previous images.

I don't remember exactly how I made existing screenshots, but probably also by using emulators.

I will really appreciate it if you could make one more attempt to create new screenshots with the highest possible resolution. If not, I don't see any blockers with merging...

The new screenshots met Google's requirements. However, they have lower resolutions than the previous version. I think that the higher resolution we upload to Google Play is better.

1. `BookmarkManager::LoadBookmarks()` [ui thread] calls `ClearCategories()` https://github.com/organicmaps/organicmaps/blob/b4aecc4eb9d77c77015dde68a4ec818d897e5fea/map/bookmark_manager.cpp#L1936-L1940 2. `BookmarkManager::ClearCategories()` [ui thread] removes all in-memory state https://github.com/organicmaps/organicmaps/blob/b4aecc4eb9d77c77015dde68a4ec818d897e5fea/map/bookmark_manager.cpp#L1895-L1910 At this point, the Bookmarks screen is empty. -------------------------------- 3. `BookmarkManager::LoadBookmarks()` [ui thread] schedules...

> LoadBookmarks was not designed to be called more than once. The fact that it is called many times now, so bookmarks are loaded (and discarded) several times, doesn't feel...