Ryan Tsao

Results 92 comments of Ryan Tsao

This is currently expected behavior (similar to this issue: https://github.com/rtsao/csjs/issues/30). getCss is just for getting the new CSS contained in that csjs literal so it can be injected. It is...

This is awesome! Cool idea of unmounting styles when the component unmounts. I might need to update docs with an ecosystem section...

This is a neat idea! So something like: ``` javascript var style = require('csjs').style; var getCss = require('csjs').getCss; var green = '#2ecc71'; var foo = style`color: ${green}; font-size: 12px`; foo.toString();...

In your browser use case, how is the CSS getting added to the page? If I understand correctly, it sounds like with electron you want to rely on the injection...

Ah, I see. Running non-bundled code inside electron was not a use case I had thought of initially (I was only thinking of server-side node and bundled code inside browsers/electron)....

That looks 99% good to me. The only errors I think I disagree with (in those specific instances) are: ``` /Users/scott/Documents/sites/csjs/lib/css-extract-extends.js:8:3: Split initialized 'var' declarations into multiple statements. /Users/scott/Documents/sites/csjs/lib/css-extract-extends.js:9:10: Expected...

`csjs-extractify` needs to run before `babelify`. I suspect this is what is happening: ``` js csjs`.foo {}` ``` is being turned into: ``` js "use strict"; var _templateObject = _taggedTemplateLiteral([".foo...

I would have a variety of use cases, but mainly standalone code generation tools and standalone non-web programming language compilers. This library has a lot of appeal compared to other...

With sourcemap: “hidden”, the `.js` doesn’t reference the map; the comment is omitted.

Great, I'll get started on implementing this.