rtrlib icon indicating copy to clipboard operation
rtrlib copied to clipboard
verified publisher icon rtrlib

rtr: Fix incomplete undo after failed table update

Open carl-tud opened this issue 2 years ago • 28 comments

Contribution description

This PR restructures rtr_sync_receive_and_store_pdus in order to fully complete an undo operation after a failed update to the prefix or spki table. Currently, changes to the respective tables are not entirely reverted if a single table undo fails. The update and undo logic was moved into separate functions, making rtr_sync_receive_and_store_pdus more comprehensible.

Additionally, this PR fixes a memory leak involving recv_loop_cleanup_args where the references to the PDUs saved temporarily aren't stored properly.

carl-tud avatar Nov 15 '23 19:11 carl-tud

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 20.04 arm8: Failed (click for details)

Make Debug failed for Ubuntu 20.04 arm8: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U2004ARM8/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
 1292 |    struct pdu_end_of_data_v0 *eod_pdu = (struct pdu_end_of_data_v0 *)pdu_data;
make[2]: *** [CMakeFiles/rtrlib_static.dir/build.make:232: CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:700: CMakeFiles/rtrlib_static.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Ubuntu 18.04 ppc64le: Failed (click for details)

Make Debug failed for Ubuntu 18.04 ppc64le: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U1804PPC64LE/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:387: recipe for target 'CMakeFiles/rtrlib.dir/all' failed
Makefile:140: recipe for target 'all' failed
make[1]: *** [CMakeFiles/rtrlib.dir/all] Error 2
make: *** [all] Error 2
Ubuntu 18.04 arm8: Failed (click for details)

Make Debug failed for Ubuntu 18.04 arm8: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U1804ARM8/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:387: recipe for target 'CMakeFiles/rtrlib.dir/all' failed
make[1]: *** [CMakeFiles/rtrlib.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
OpenBSD 7 amd64: Failed (click for details)

Make Debug failed for OpenBSD 7 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/OBSD6AMD64/ErrorLog/log_make_debug.txt)

[  1%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr_mgr.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  3%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/utils.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  4%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/alloc_utils.c.o
Debian 11 amd64: Failed (click for details)

Make Debug failed for Debian 11 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/DEB11AMD64/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
 1292 |    struct pdu_end_of_data_v0 *eod_pdu = (struct pdu_end_of_data_v0 *)pdu_data;
make[2]: *** [CMakeFiles/rtrlib_static.dir/build.make:251: CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:719: CMakeFiles/rtrlib_static.dir/all] Error 2
make: *** [Makefile:160: all] Error 2
FreeBSD 12 amd64: Failed (click for details)

Make Debug failed for FreeBSD 12 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FBSD12AMD64/ErrorLog/log_make_debug.txt)

[  1%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr_mgr.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  3%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/utils.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  4%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/alloc_utils.c.o
Debian 10 amd64: Failed (click for details)

Make Debug failed for Debian 10 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/DEB10AMD64/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
make[2]: *** [CMakeFiles/rtrlib.dir/build.make:232: CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:393: CMakeFiles/rtrlib.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
FreeBSD 11 amd64: Failed (click for details)

Make Debug failed for FreeBSD 11 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FBSD11AMD64/ErrorLog/log_make_debug.txt)

[  1%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr_mgr.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  3%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/utils.c.o
warning: unknown warning option '-Wfree-nonheap-object'; did you mean '-Wsequence-point'? [-Wunknown-warning-option]
warning: unknown warning option '-Werror=cast-function-type'; did you mean '-Werror=bad-function-cast'? [-Wunknown-warning-option]
2 warnings generated.
[  4%] Building C object CMakeFiles/rtrlib.dir/rtrlib/lib/alloc_utils.c.o
Redhat 8 amd64: Failed (click for details)

Make Debug failed for Redhat 8 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/REDHAT8/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
make[2]: *** [CMakeFiles/rtrlib.dir/build.make:258: CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:469: CMakeFiles/rtrlib.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
Fedora 35 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 35 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FEDORA35/ErrorLog/log_make_test_debug.txt
NetBSD 9 amd64: Failed (click for details)

Make Debug failed for NetBSD 9 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/NBSD7AMD64/ErrorLog/log_make_debug.txt)

[ 21%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function 'rtr_sync_receive_and_store_pdus':
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
*** Error code 1
Stop.
make[2]: stopped in /home/ci/cibuild.411/rtrlib-source
*** Error code 1
Stop.
make[1]: stopped in /home/ci/cibuild.411/rtrlib-source
Redhat 9 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt
Fedora 31 amd64: Failed (click for details)

Make Debug failed for Fedora 31 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FED31BUILD/ErrorLog/log_make_debug.txt)

[ 21%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
 1292 |    struct pdu_end_of_data_v0 *eod_pdu = (struct pdu_end_of_data_v0 *)pdu_data;
make[2]: *** [CMakeFiles/rtrlib_static.dir/build.make:252: CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:639: CMakeFiles/rtrlib_static.dir/all] Error 2
make: *** [Makefile:161: all] Error 2
Fedora 29 amd64: Failed (click for details)

Make Debug failed for Fedora 29 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/FEDORA29AMD64/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
make[2]: *** [CMakeFiles/rtrlib.dir/build.make:232: CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:393: CMakeFiles/rtrlib.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Ubuntu 18.04 amd64: Failed (click for details)

Make Debug failed for Ubuntu 18.04 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U1804AMD64/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:387: recipe for target 'CMakeFiles/rtrlib.dir/all' failed
Makefile:140: recipe for target 'all' failed
make[1]: *** [CMakeFiles/rtrlib.dir/all] Error 2
make: *** [all] Error 2
Ubuntu 18.04 i386: Failed (click for details)

Make Debug failed for Ubuntu 18.04 i386: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U18I386/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib_static.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:451: recipe for target 'CMakeFiles/rtrlib_static.dir/all' failed
make[1]: *** [CMakeFiles/rtrlib_static.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2
CentOS 7 amd64: Failed (click for details)

Make Debug failed for CentOS 7 amd64: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/CENTOS7AMD64/ErrorLog/log_make_debug.txt)

[ 27%] Building C object CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
make[2]: *** [CMakeFiles/rtrlib.dir/rtrlib/rtr/packets.c.o] Error 1
make[1]: *** [CMakeFiles/rtrlib.dir/all] Error 2
make: *** [all] Error 2
Ubuntu 18.04 arm7: Failed (click for details)

Make Debug failed for Ubuntu 18.04 arm7: (see full Make Debug log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-411/artifact/U1804ARM7/ErrorLog/log_make_debug.txt)

[ 19%] Building C object CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c: In function rtr_sync_receive_and_store_pdus:
/home/ci/cibuild.411/rtrlib-source/rtrlib/rtr/packets.c:1292:4: error: a label can only be part of a statement and a declaration is not a statement
CMakeFiles/rtrlib_static.dir/build.make:374: recipe for target 'CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o' failed
make[2]: *** [CMakeFiles/rtrlib_static.dir/rtrlib/rtr/packets.c.o] Error 1
CMakeFiles/Makefile2:451: recipe for target 'CMakeFiles/rtrlib_static.dir/all' failed
make[1]: *** [CMakeFiles/rtrlib_static.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

NetDEF-CI avatar Nov 15 '23 19:11 NetDEF-CI

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 20.04 arm8: Failed (click for details) __Unittests (make test) failed for Ubuntu 20.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U2004ARM8/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 arm8: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U1804ARM8/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 ppc64le: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 amd64: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U1804AMD64/ErrorLog/log_make_test_debug.txt
Debian 11 amd64: Failed (click for details) __Unittests (make test) failed for Debian 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/DEB11AMD64/ErrorLog/log_make_test_debug.txt
FreeBSD 12 amd64: Failed (click for details) __Unittests (make test) failed for FreeBSD 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FBSD12AMD64/ErrorLog/log_make_test_debug.txt
OpenBSD 7 amd64: Failed (click for details) __Unittests (make test) failed for OpenBSD 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/OBSD6AMD64/ErrorLog/log_make_test_debug.txt
Redhat 8 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 8 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/REDHAT8/ErrorLog/log_make_test_debug.txt
FreeBSD 11 amd64: Failed (click for details) __Unittests (make test) failed for FreeBSD 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FBSD11AMD64/ErrorLog/log_make_test_debug.txt
NetBSD 9 amd64: Failed (click for details) __Unittests (make test) failed for NetBSD 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/NBSD7AMD64/ErrorLog/log_make_test_debug.txt
Fedora 35 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 35 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FEDORA35/ErrorLog/log_make_test_debug.txt
Redhat 9 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt
Fedora 31 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 31 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FED31BUILD/ErrorLog/log_make_test_debug.txt
Debian 10 amd64: Failed (click for details) __Unittests (make test) failed for Debian 10 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/DEB10AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 arm7: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt
Fedora 29 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 29 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/FEDORA29AMD64/ErrorLog/log_make_test_debug.txt
CentOS 7 amd64: Failed (click for details) __Unittests (make test) failed for CentOS 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/CENTOS7AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 i386: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 i386__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-412/artifact/U18I386/ErrorLog/log_make_test_debug.txt

NetDEF-CI avatar Nov 15 '23 19:11 NetDEF-CI

test_live_validation and test_dynamic_groups seem to fail for rtrlib:master, too (gcc 11.4.0, Ubuntu 22.04, arm64) edit: rpki-validator.realmv6.org refuses connection, seems to be down

carl-tud avatar Nov 15 '23 19:11 carl-tud

thanks @carl-tud. yes, rpki-validator.realmv6.org is down. i will check later.

waehlisch avatar Nov 15 '23 20:11 waehlisch

brief update: we will set up a new validator, but it will take some days due to internal clearance procedures. @Nimuedaertya will take care of this.

waehlisch avatar Nov 18 '23 15:11 waehlisch

@carl-tud can you rebase? the tests should pass now (see #282).

waehlisch avatar Nov 21 '23 19:11 waehlisch

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Fedora 35 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 35 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FEDORA35/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 arm7: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt
Redhat 8 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 8 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/REDHAT8/ErrorLog/log_make_test_debug.txt
Fedora 29 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 29 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FEDORA29AMD64/ErrorLog/log_make_test_debug.txt
NetBSD 9 amd64: Failed (click for details) __Unittests (make test) failed for NetBSD 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/NBSD7AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 i386: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 i386__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U18I386/ErrorLog/log_make_test_debug.txt
Debian 12 amd64: Failed (click for details) __Unittests (make test) failed for Debian 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/D12AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 20.04 arm8: Failed (click for details) __Unittests (make test) failed for Ubuntu 20.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U2004ARM8/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 arm8: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U1804ARM8/ErrorLog/log_make_test_debug.txt
OpenBSD 7 amd64: Failed (click for details) __Unittests (make test) failed for OpenBSD 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/OBSD6AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 amd64: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U1804AMD64/ErrorLog/log_make_test_debug.txt
CentOS 7 amd64: Failed (click for details) __Unittests (make test) failed for CentOS 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/CENTOS7AMD64/ErrorLog/log_make_test_debug.txt
Fedora 31 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 31 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FED31BUILD/ErrorLog/log_make_test_debug.txt
Redhat 9 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt
Debian 11 amd64: Failed (click for details) __Unittests (make test) failed for Debian 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/DEB11AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 ppc64le: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt
FreeBSD 12 amd64: Failed (click for details) __Unittests (make test) failed for FreeBSD 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FBSD12AMD64/ErrorLog/log_make_test_debug.txt
FreeBSD 11 amd64: Failed (click for details) __Unittests (make test) failed for FreeBSD 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/FBSD11AMD64/ErrorLog/log_make_test_debug.txt
Debian 10 amd64: Failed (click for details) __Unittests (make test) failed for Debian 10 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-421/artifact/DEB10AMD64/ErrorLog/log_make_test_debug.txt

NetDEF-CI avatar Nov 23 '23 18:11 NetDEF-CI

CI:rerun

waehlisch avatar Nov 23 '23 18:11 waehlisch

CI:rerun

waehlisch avatar Nov 24 '23 10:11 waehlisch

CI:rerun

waehlisch avatar Nov 24 '23 10:11 waehlisch

CI:rerun

waehlisch avatar Nov 24 '23 10:11 waehlisch

CI:rerun

waehlisch avatar Nov 24 '23 10:11 waehlisch

Continuous Integration Result: FAILED

Test incomplete. See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-424/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Fedora 35 amd64: Incomplete (check logs for details)
Ubuntu 18.04 i386: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 i386__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-424/artifact/U18I386/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 arm7: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-424/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 ppc64le: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-424/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt
Successful on other platforms/tests
  • NetBSD 9 amd64
  • Redhat 8 amd64
  • Fedora 29 amd64
  • Debian 12 amd64
  • Ubuntu 18.04 amd64
  • OpenBSD 7 amd64
  • Ubuntu 20.04 arm8
  • Ubuntu 18.04 arm8
  • CentOS 7 amd64
  • Redhat 9 amd64
  • Fedora 31 amd64
  • Debian 10 amd64
  • FreeBSD 12 amd64
  • Debian 11 amd64
  • FreeBSD 11 amd64

NetDEF-CI avatar Nov 24 '23 10:11 NetDEF-CI

the results of the CI tests are very confusing. rerunning the CI leads to different results. sometimes the live test_live_validation and test_dynamic_groups fail, sometimes they pass. if make test outside of the CI, the tests always pass.

we should have stable CI tests before merging.

waehlisch avatar Nov 24 '23 10:11 waehlisch

Continuous Integration Result: FAILED

Test incomplete. See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Redhat 8 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 8 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/REDHAT8/ErrorLog/log_make_test_debug.txt
Fedora 29 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 29 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/FEDORA29AMD64/ErrorLog/log_make_test_debug.txt
Redhat 9 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt
Fedora 31 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 31 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/FED31BUILD/ErrorLog/log_make_test_debug.txt
CentOS 7 amd64: Failed (click for details) __Unittests (make test) failed for CentOS 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/CENTOS7AMD64/ErrorLog/log_make_test_debug.txt
OpenBSD 7 amd64: Failed (click for details) __Unittests (make test) failed for OpenBSD 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/OBSD6AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 arm7: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 ppc64le: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt
Ubuntu 20.04 arm8: Failed (click for details) __Unittests (make test) failed for Ubuntu 20.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/U2004ARM8/ErrorLog/log_make_test_release.txt
Ubuntu 18.04 arm8: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/U1804ARM8/ErrorLog/log_make_test_release.txt
Debian 11 amd64: Failed (click for details) __Unittests (make test) failed for Debian 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/DEB11AMD64/ErrorLog/log_make_test_debug.txt
FreeBSD 12 amd64: Failed (click for details) __Unittests (make test) failed for FreeBSD 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/FBSD12AMD64/ErrorLog/log_make_test_debug.txt
Debian 10 amd64: Failed (click for details) __Unittests (make test) failed for Debian 10 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/DEB10AMD64/ErrorLog/log_make_test_debug.txt
FreeBSD 11 amd64: Failed (click for details) __Unittests (make test) failed for FreeBSD 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-425/artifact/FBSD11AMD64/ErrorLog/log_make_test_debug.txt
Fedora 35 amd64: Incomplete (check logs for details)
Successful on other platforms/tests
  • NetBSD 9 amd64
  • Debian 12 amd64
  • Ubuntu 18.04 i386
  • Ubuntu 18.04 amd64

NetDEF-CI avatar Nov 24 '23 10:11 NetDEF-CI

my suggestion is that @Nimuedaertya creates a dummy PR that doesn't include any code changes to better understand what is going on with the CI.

waehlisch avatar Nov 24 '23 10:11 waehlisch

Continuous Integration Result: FAILED

Test incomplete. See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Debian 12 amd64: Failed (click for details) __Unittests (make test) failed for Debian 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/D12AMD64/ErrorLog/log_make_test_debug.txt
Fedora 31 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 31 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/FED31BUILD/ErrorLog/log_make_test_debug.txt
Redhat 9 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/RH9BUILD/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 amd64: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U1804AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 i386: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 i386__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U18I386/ErrorLog/log_make_test_debug.txt
Fedora 29 amd64: Failed (click for details) __Unittests (make test) failed for Fedora 29 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/FEDORA29AMD64/ErrorLog/log_make_test_debug.txt
CentOS 7 amd64: Failed (click for details) __Unittests (make test) failed for CentOS 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/CENTOS7AMD64/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 arm7: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 ppc64le: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt
Ubuntu 20.04 arm8: Failed (click for details) __Unittests (make test) failed for Ubuntu 20.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U2004ARM8/ErrorLog/log_make_test_release.txt
Ubuntu 18.04 arm8: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm8__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/U1804ARM8/ErrorLog/log_make_test_release.txt
OpenBSD 7 amd64: Failed (click for details) __Unittests (make test) failed for OpenBSD 7 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/OBSD6AMD64/ErrorLog/log_make_test_debug.txt
Debian 10 amd64: Failed (click for details) __Unittests (make test) failed for Debian 10 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/DEB10AMD64/ErrorLog/log_make_test_debug.txt
Debian 11 amd64: Failed (click for details) __Unittests (make test) failed for Debian 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/DEB11AMD64/ErrorLog/log_make_test_debug.txt
FreeBSD 12 amd64: Failed (click for details) __Unittests (make test) failed for FreeBSD 12 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/FBSD12AMD64/ErrorLog/log_make_test_debug.txt
Redhat 8 amd64: Failed (click for details) __Unittests (make test) failed for Redhat 8 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/REDHAT8/ErrorLog/log_make_test_debug.txt
FreeBSD 11 amd64: Failed (click for details) __Unittests (make test) failed for FreeBSD 11 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/FBSD11AMD64/ErrorLog/log_make_test_debug.txt
Fedora 35 amd64: Incomplete (check logs for details)
NetBSD 9 amd64: Failed (click for details) __Unittests (make test) failed for NetBSD 9 amd64__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-426/artifact/NBSD7AMD64/ErrorLog/log_make_test_debug.txt

NetDEF-CI avatar Nov 24 '23 11:11 NetDEF-CI

At least for me, locally, test_live_validation and test_dynamic_groups are both finishing with exit code 0. When I tried running these tests yesterday (23/11/2023) evening, they failed because of an error PDU from the cache server (code 2, custom msg was something like "Running initial validation")

carl-tud avatar Nov 24 '23 11:11 carl-tud

When I tried running these tests yesterday (23/11/2023) evening, they failed because of an error PDU from the cache server (code 2, custom msg was something like "Running initial validation")

yes, the validator was not running stable. we fixed this today morning.

waehlisch avatar Nov 24 '23 12:11 waehlisch

CI:rerun

carl-tud avatar Nov 29 '23 12:11 carl-tud

Continuous Integration Result: FAILED

Test incomplete. See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/RPKI-RTRLIBPR-432/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Ubuntu 18.04 ppc64le: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 ppc64le__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-432/artifact/U1804PPC64LE/ErrorLog/log_make_test_debug.txt
Ubuntu 18.04 arm7: Failed (click for details) __Unittests (make test) failed for Ubuntu 18.04 arm7__ see Unittest log at https://ci1.netdef.org/browse/RPKI-RTRLIBPR-432/artifact/U1804ARM7/ErrorLog/log_make_test_debug.txt
Fedora 35 amd64: Incomplete (check logs for details)
Successful on other platforms/tests
  • Fedora 31 amd64
  • Redhat 9 amd64
  • Debian 10 amd64
  • FreeBSD 11 amd64
  • Fedora 29 amd64
  • CentOS 7 amd64
  • Ubuntu 18.04 amd64
  • Ubuntu 18.04 i386
  • FreeBSD 12 amd64
  • Debian 11 amd64
  • OpenBSD 7 amd64
  • NetBSD 9 amd64
  • Redhat 8 amd64
  • Ubuntu 20.04 arm8
  • Ubuntu 18.04 arm8
  • Debian 12 amd64

NetDEF-CI avatar Nov 29 '23 13:11 NetDEF-CI

@carl-tud what is the status of this PR?

fho avatar Apr 01 '24 08:04 fho

The changes I‘ve made for this PR are included in #285 . This PR was just to get some of the changes not directly related ASPA, but the update logic out before the final ASPA PR. Do you think we should still merge this PR first?

carl-tud avatar Apr 15 '24 07:04 carl-tud

@carl-tud as you prefer :-) Ideally we would get in these changes unrelated to ASPA with a separate PR. If you don't want to bother it with and spend additional time with merge conflicts, etc, closing it and getting the changes in with #285 is also fine. We should ensure that the fixes do not get lost in the changelog in that case.

fho avatar Apr 16 '24 08:04 fho

@carl-tud as you prefer :-) Ideally we would get in these changes unrelated to ASPA with a separate PR. If you don't want to bother it with and spend additional time with merge conflicts, etc, closing it and getting the changes in with #285 is also fine. We should ensure that the fixes do not get lost in the changelog in that case.

Sorry for the late reply, in theory I'd be totally okay with that, but, reading #285 it looks like ASPA is going to be introduced as part of a new version (with potentially source-breaking changes), so this might be needed as bugfix for those temporarily staying on the older version..?

carl-tud avatar May 22 '24 15:05 carl-tud

CI:rerun

Nimuedaertya avatar Jun 11 '24 17:06 Nimuedaertya

CI:rerun

waehlisch avatar Aug 12 '24 20:08 waehlisch

CI:rerun

edit: somehow didnt work

Nimuedaertya avatar Sep 29 '24 20:09 Nimuedaertya