mantine-v7 icon indicating copy to clipboard operation
mantine-v7 copied to clipboard

<Select/> is missing onSearchChange & searchValue props

Open Twisterking opened this issue 2 years ago • 2 comments

What package has an issue

@mantine/core

Describe the bug

The <MultiSelect/>(Link) does have these 2 props in addition to the searchable prop to properly use the search functionality, but the <Select/> (Link) is missing those.

This does not really make sense to me, as both do have the searchable prop, but without onSearchChange and searchValue the search functionality is highly limited for the <Search/> component for no apparent reason.

What version of @mantine/* page do you have in package.json? (Note that all @mantine/* packages must have the same version in order to work correctly)

7.0.0-beta.1

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

None

Are you willing to participate in fixing this issue and create a pull request with the fix

None

Possible fix

No response

Twisterking avatar Aug 28 '23 09:08 Twisterking

See https://v7.mantine.dev/core/select#combobox

rtivital avatar Aug 28 '23 10:08 rtivital

I understand that I can now build my own Comboboxes with the new setup - great job by the way! :) I just do not understand why one or the other "opinionated component" should contain "half" of the search functionality and the other "the full set". This seems weird to me.

Twisterking avatar Aug 28 '23 11:08 Twisterking