libchdr icon indicating copy to clipboard operation
libchdr copied to clipboard

Compression format AVHuff not supported

Open edc71 opened this issue 3 years ago • 6 comments

AVHuff is the format used for laserdisks.. its used since v3 afaik

edc71 avatar Jan 11 '22 22:01 edc71

@edc71 you're right. I could add AVHuff support for sure but I have to find a way to not bloat too much libchdr which is meant to be easily embeddable in other projects with a small footprint.

rtissera avatar Jan 11 '22 22:01 rtissera

Could always be optional support. If compiled with support, include requisite lib. That way it's available for projects that need it, but doesn't muss up those that don't. Though I suppose that does run contrary to recent efforts to make libchdr more uniform. Hrm.

Sanaki avatar Jan 11 '22 23:01 Sanaki

I agree with you @Sanaki meanwhile I had a look at AVHuff, hopefully it only depends on (possibly) flac which is already in through dr_flac and some huffman decoder so that's not a lot of code. Worth having a look implementing it. @edc71 what's the typical use case ? Daphne / Hypseus Singe ?

rtissera avatar Jan 11 '22 23:01 rtissera

Seems like it, though I asked him to open this issue when the topic arose while looking at usage of libchdr with RomVault for data validation purposes. Obviously MAME would be a use case, though I'm not sure under what circumstances this library would come into use with it offhand.

Sanaki avatar Jan 11 '22 23:01 Sanaki

I agree with you @Sanaki meanwhile I had a look at AVHuff, hopefully it only depends on (possibly) flac which is already in through dr_flac and some huffman decoder so that's not a lot of code. Worth having a look implementing it. @edc71 what's the typical use case ? Daphne / Hypseus Singe ?

Its actually for a tool which enters rominfo into a database. But hashing chd isnt enough, because the dats are using different hashes. So I needed something simple to include. And also like Sanaki said, it is also been looked at for usage in RomVault

edc71 avatar Jan 12 '22 13:01 edc71

Okay. I will start a dev branch to add it. I also want to fix a bad warning (wrong free) and bump lzma so timing is good.

Will ping you and hypseus singe devs when done.

Envoyé de mon iPhone

Le 12 janv. 2022 à 14:02, edc71 @.***> a écrit :

 I agree with you @Sanaki meanwhile I had a look at AVHuff, hopefully it only depends on (possibly) flac which is already in through dr_flac and some huffman decoder so that's not a lot of code. Worth having a look implementing it. @edc71 what's the typical use case ? Daphne / Hypseus Singe ?

Its actually for a tool which enters rominfo into a database. But hashing chd isnt enough, because the dats are using different hashes. So I needed something simple to include.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

rtissera avatar Jan 12 '22 13:01 rtissera