rtic icon indicating copy to clipboard operation
rtic copied to clipboard

actor API

Open japaric opened this issue 2 years ago • 8 comments

this PR contains a proof-of-concept implementation of the actor API proposed in rtic-rs/rfcs#52 the files added to the examples directory are tests of the feature semantics a full example, with multiple crates (firmware + testable no_std library), has been included in the actor-example directory

depends on https://github.com/rtic-rs/rtic-syntax/pull/75

japaric avatar Sep 27 '21 13:09 japaric

@rtic-rs/devs this PR has been rebased onto rtic 1.0 and the deps of the firmware have also been bumped :rocket:

japaric avatar Jan 28 '22 12:01 japaric

ping @korken89 this and the rtic-syntax PRs have been rebased

japaric avatar May 03 '22 16:05 japaric

Now with v1.1 out the door I think it's time to give this the attention for a v1.2 release.

korken89 avatar May 12 '22 12:05 korken89

Looking at the actor-example multi-crate example I am curious as to why FakeTempratureSensor is defined as an actor in the actor crate then not listed in the Actors struct. Instead an instance of it saved in Local. Why would you not just save a copy of the Poster in Local and have the periodic task use that to post a message into the Actor system. Seems confusing to have an Actor that isn't quite used as an Actor.

jscatena88 avatar Jun 03 '22 17:06 jscatena88

indeed, having the temp sensor as an actor instance makes more sense. updated the example.

japaric avatar Jun 07 '22 09:06 japaric

@korken89 review ping. (someone else also asked about when this would be merged in the matrix chat room)

japaric avatar Jul 07 '22 12:07 japaric

What's the status of this, now that v2.0 is stable?

bb010g avatar Jun 02 '23 10:06 bb010g

What's the status of this, now that v2.0 is stable?

The proposed path forward is to create a separate branch for actor, just like other older releases. I did rebase this actor branch onto latest RTIC v1, then they could be released as alphas or similar.

AfoHT avatar Jun 07 '23 17:06 AfoHT