cra-generate icon indicating copy to clipboard operation
cra-generate copied to clipboard

Skipping css file

Open eirikurn opened this issue 7 years ago • 2 comments

For js-in-css projects, we don't want a css file for components. Would be nice to have a project setting to skip that, like we can already skip the tests.

eirikurn avatar Oct 19 '17 15:10 eirikurn

Good point! I'm wondering if the correct way to go about this would be to rename the "cssExtension" property to "css" and accept false as a value, in addition to css extension strings. Eg

interface OptionsT {
  [otherOptions: string]: any,
  css: false | string,
}

This way we support both and could pass correct overrides in the cli:

cra-generate Foo --css=false

rthor avatar Oct 20 '17 11:10 rthor

I like that.

On Fri, Oct 20, 2017 at 11:55 AM Ragnar Þór Valgeirsson < [email protected]> wrote:

Good point! I'm wondering if the correct way to go about this would be rename the "cssExtension" property to "css" and accept false as a value, in addition to css extensions strings. Eg

interface OptionsT { [otherOptions: string]: any, css: false | string, }

This way we support both and could pass correct overrides in the cli:

cra-generate Foo --css=false

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rthor/cra-generate/issues/24#issuecomment-338185719, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHBlgsrOlJOM_eyJdeyb-Hpgbv9lasFks5suIo7gaJpZM4P_Xzo .

eirikurn avatar Oct 20 '17 13:10 eirikurn