diff2html icon indicating copy to clipboard operation
diff2html copied to clipboard

Backslashes removed in title e.g. C:\dev\alex\test.json -> C:devalex.json

Open alexsuter opened this issue 1 year ago • 1 comments

Step -1: Before filling an issue check out troubleshooting section

Step 0: Describe your environment

  • OS: everywhere
  • diff2html version: latest
  • Using diff2html directly or using diff2html-ui helper: diff2html
  • Extra flags: not relevant

Step 1: Describe the problem:

Steps to reproduce:

  1. Use a patch with windows paths

diff example:

diff --git a/sample.js b/sample.js
index 0000001..0ddf2ba
--- C:\dev\alex.js
+++ b/sample.js
@@ -1 +1 @@
-console.log("Hello World!")
+console.log("Hello from Diff2Html!")

Observed Results:

  • Backslashes removed in title e.g. C:\dev\alex\test.json -> C:devalex.json

Expected Results:

  • Backslashes won't be removed

Relevant Code:

image

alexsuter avatar Feb 06 '24 07:02 alexsuter

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0b0f2ab) 58.67% compared to head (ba937e1) 58.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   58.67%   58.67%           
=======================================
  Files          14       14           
  Lines        1585     1585           
=======================================
  Hits          930      930           
  Misses        655      655           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 07 '24 13:02 codecov-commenter

Looks like unicode-segmentation is up-to-date now, so this is no longer needed.

dependabot[bot] avatar Feb 19 '24 19:02 dependabot[bot]