action-slack-notify icon indicating copy to clipboard operation
action-slack-notify copied to clipboard

WebHooks method is deprecated; update to GitHub Apps.

Open sarina opened this issue 2 years ago • 5 comments

Hi,

The instructions say to use a webhook to configure:

You can generate a Slack incoming webhook token from here.

However this method is deprecated. This Action needs to be upgraded to use the suggested method.

Screen Shot 2022-02-13 at 12 37 33

Thanks!

sarina avatar Feb 13 '22 17:02 sarina

Hello, I could replace it with chat.postMessage. What do you think?

xrisaD avatar Apr 05 '22 21:04 xrisaD

I think it might have more impact than documentation. I use action-slack-notify with a Slack App but the webhook you obtain is tied to a channel. So the SLACK_CHANNEL parameter won't be used anymore.

Note: As I'm just starting to use this action, I may have missed some way to configure it.

titimoby avatar Apr 06 '22 09:04 titimoby

Apologies for not adding what I did. I used a Slack app to do this integration. I guess I never even used this Action. https://github.com/openedx/.github/blob/master/.github/workflows/add-depr-ticket-to-depr-board.yml#L85-L92

sarina avatar Apr 06 '22 13:04 sarina

The instructions say to use a webhook to configure:

You can generate a Slack incoming webhook token from here.

However this method is deprecated. This Action needs to be upgraded to use the suggested method.

Agree that documentation should be updated to non-deprecated method. Slack Apps should be default moving forward.

However, I would prefer to keep the existing deprecated functionality in place until Slack actually removes it.

BrianInAz avatar May 30 '22 16:05 BrianInAz

However, I would prefer to keep the existing deprecated functionality in place until Slack actually removes it.

Why? I was creating a brand new integration and I strongly preferred to not use a functionality that would be soon deprecated and cause me to have to re-implement it. Why not at least have both instructions?

sarina avatar May 31 '22 15:05 sarina