redux-persist
redux-persist copied to clipboard
Move @types/react to dependencies.
Because @types/react is placed in devDependencies, I cannot have @types/redux-persist-expire test passed. Why it can't? My package depends on a type which redux-persist exposes, so it declares redux-persist as a dependency. When DefinitelyTyped's CI runs, it installs dependent packages then run tests and fails. @types/react won't be installed because it is declared in devDependencies.
As well as source code itself, @types dependencies should also be installed when install the library.
Just install it as a dependency in your project, it's not a dependency of this project.
I can't install it in my project which is a DefinitelyTyped's subproject. Because DT doesn't permit me to install it in devDependencies.
Further discuttions:
dependencies is preferred way in our case as long as I understand it.
In addition to what I mentioned above, DT doesn't permit me to import what I don't directly use. @types/react is an indirect dependency for my package.