redux-persist-crosstab icon indicating copy to clipboard operation
redux-persist-crosstab copied to clipboard

Published 20 hours ago • verified publisher icon rt2zz

Ensure localStorage is not fired in the source window with IE9/10

Open thisiskylierose opened this issue 9 years ago • 5 comments

HTML5 localStorage implementation in IE 9/10 does not match the spec. This is a known issue and the pull request addresses a work-around. Please test and feedback any changes required. See link below for more details on the problem.

https://connect.microsoft.com/IE/feedback/details/774798/localstorage-event-fired-in-source-window

thisiskylierose avatar Nov 25 '15 01:11 thisiskylierose

@thisiskylierose why did you close?

rt2zz avatar Nov 26 '15 06:11 rt2zz

I need to do some more testing on the changes first.

thisiskylierose avatar Nov 26 '15 06:11 thisiskylierose

Please have a look now - have tested these changes more with redux in a build and it seems to be working well. Need to run tests in IE9/10 to make sure those browsers play nice. :)

thisiskylierose avatar Nov 27 '15 01:11 thisiskylierose

Dev branch has console logs: https://github.com/thisiskylierose/redux-persist-crosstab/tree/development

thisiskylierose avatar Nov 27 '15 01:11 thisiskylierose

This seems to be assuming the focused window is the source window. While that may be true for your specific application, it is not true in general.

For example, we sometimes trigger redux updates as a result of an HTTP response, which may come in while a different window/tab is in focus.

aij avatar Nov 09 '16 16:11 aij