rsyslog-pkg-rhel-centos icon indicating copy to clipboard operation
rsyslog-pkg-rhel-centos copied to clipboard

The v8-stable-el7.spec file contains an chmod +x /usr/bin/* directive in build

Open itkovian opened this issue 4 years ago • 2 comments

Line 389

%build
chmod +x /usr/bin/*

Any reason for this? Seems like this is not really something we would want to do; it also breaks building the RPM as a non-root user.

itkovian avatar Mar 23 '20 16:03 itkovian

Bump. It doesn't really seem necessary (or is necessary in only some very strange case) but indeed does break building with mock.

mkrsfcmp avatar May 11 '22 13:05 mkrsfcmp

This command is applied inside the mock environment, it was added a few years ago in commit https://github.com/rsyslog/rsyslog-pkg-rhel-centos/commit/c17d75a55346319b9c22697b28e9ef0194670317 as workaround with problems building packages inside a docker container. I didn't spend more time investigating why there was a permission problem inside mock environment which is dynamically created each time.

Perhaps you should use our Fedora 30 based docker container for building? It has all requirements installed needed for building, and it does not need root to run the docker image. See the run.sh shript in our docker repository: https://github.com/rsyslog/rsyslog-docker/blob/master/dev_env/fedora/pkg_base/30/run.sh

alorbach avatar May 12 '22 07:05 alorbach