liblognorm icon indicating copy to clipboard operation
liblognorm copied to clipboard

LOGNORMALIZER::CHANGED:: when using '-V' flag, return 0 (zero) when program exits

Open frikilax opened this issue 2 years ago • 3 comments

Description

When printing lognormalizer's version through its '-V' flag, the return code is not zero, that return code is counter intuitive and prevents using the command in scripts and/or CI/CD frameworks

Changed

  • return zero when '-V' flag is detected after printing the version number, instead of 1

frikilax avatar Oct 13 '22 12:10 frikilax

oops... that sounds indeed bad.

I would say this does not case a real backwards-compatibilty issue as the tool itself is not used that often. @davidelang what do you think (we are talking about the stand-alone tool, not the rsyslog integration)?

rgerhards avatar Oct 13 '22 13:10 rgerhards

sounds like a mistake, and one that it's very unlikely that anyone is going to depend on, so I would say it's reasonable to fix it.

David Lang

On Thu, 13 Oct 2022, Rainer Gerhards wrote:

oops... that sounds indeed bad.

I would say this does not case a real backwards-compatibilty issue as the tool itself is not used that often. @davidelang what do you think (we are talking about the stand-alone tool, not the rsyslog integration)?

davidelang avatar Oct 13 '22 13:10 davidelang

@davidelang thx!

rgerhards avatar Oct 13 '22 13:10 rgerhards