hyperbole hywiki active when global minor mode disabled?

[Overdr0ne]

I was profiling some sluggishness and was surprised to see a hywiki function show up:

          31  42% + command-execute
          15  20% + redisplay_internal (C function)
          14  19% + timer-event-handler
           5   6% + eldoc-pre-command-refresh-echo-area
           4   5% + #<compiled -0xae28356f5bf1b7f>
           4   5% - hywiki-buttonize-non-character-commands
           4   5%  - hywiki-non-hook-context-p
           4   5%     syntax-ppss
           0   0% + ...

My use-package:

(use-package hyperbole
  :init
  (setopt hkey-init nil))

hyperbole-mode and all other hy*-modes are nil.

I'm using version 8.0.0 I notice a suspicious looking "Public Initializations" section at the end of hywiki.el, that resolves to hywiki-buttonize-non-character-commands. Maybe that should be part of the minor mode enable initialization?

Could you please take a look?

[rswgnu]

Thanks for pointing this out. Will take a look. hywiki-mode controls whether hywiki words work outside of the hywiki-directory. But the hooks stay in place for when you are editing org files within hywiki-directory. Maybe we could make the hooks local to these buffers only. Maybe another flag to disable the hooks when in the hywiki-directory.

[rswgnu]

You can’t be using hyperb:version 8.0.0 since HyWiki did not exist then. You must be on one of the latest pre-releases.

[Overdr0ne]

Yes, you are right, the git tag is actually hyperbole-9.0.1. However, describe-package is showing 8.0.0. I'm not sure where it's getting that version then

[Overdr0ne]

Thanks for pointing this out. Will take a look. hywiki-mode controls whether hywiki words work outside of the hywiki-directory. But the hooks stay in place for when you are editing org files within hywiki-directory. Maybe we could make the hooks local to these buffers only. Maybe another flag to disable the hooks when in the hywiki-directory.

Hmm, if that is a fixed directory, seems like a good use case for directory variables. Not knowing the details, you could maybe add the hooks when the hywiki mode is enabled, then enable hywiki-mode in the directory variables. Or maybe use auto-mode-alist with some regexps for the same effect. Just some ideas...