hyperbole
hyperbole copied to clipboard
rswgnu
update docker for batch tests
What
Run batch tests for multiple Emacs versions using docker
Bases on the PR: https://github.com/rswgnu/hyperbole/pull/549
Use basename docker, depend on update to ensure latest image
Why
We want to be able to run the tests locally covering the same tests as the CI/CD and even cover the interactive tests.
Note
This is based on https://github.com/rswgnu/hyperbole/pull/549. Preferably merge that PR first.
The earlier PR was approved awhile back. Quick changes requested on this one.-- BobOn Jun 28, 2024, at 4:33 PM, Mats Lidell @.***> wrote: @matsl requested your review on: #551 update docker for batch tests.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>
The earlier PR was approved awhile back.
Thanks @rswgnu, I know. We have high quality standards, :smile:, so since all required statuses have not been met I can't merge the PR. This is enforced by GitHub and not a rule put on ourselves. That goes for other PRs that has been approved as well. That is why we need to fix the master branch to unblock our work. See PR #548 that resolved the block. (Fixing that is the preferred way to go rather than you overriding the merge blocker as the repository owner IMHO.)
I have been working on rewriting PR #548 as I want to do a bunch of that differently. I am actively working on it today, but figure that that PR will simply be dropped and replaced by another update. You'll probably have to wait for my update to apply your additional fixes then but they'll basically be approved at that point.
On Sat, Jun 29, 2024 at 4:15 AM Mats Lidell @.***> wrote:
The earlier PR was approved awhile back.
Thanks @rswgnu https://github.com/rswgnu, I know. We have high quality standards, 😄, so since all required statuses have not been met I can't merge the PR. This is enforced by GitHub and not a rule put on ourselves. That goes for other PRs that has been approved as well. That is why we need to fix the master branch to unblock our work. See PR #548 https://github.com/rswgnu/hyperbole/pull/548 that resolved the block. (Fixing that is the preferred way to go rather than you overriding the merge blocker as the repository owner IMHO.)
— Reply to this email directly, view it on GitHub https://github.com/rswgnu/hyperbole/pull/551#issuecomment-2198043283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5WPD2FEW3XXHQ47GCJ4OLZJZUITAVCNFSM6AAAAABKCPAIEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGA2DGMRYGM . You are receiving this because you were mentioned.Message ID: @.***>
I have been working on rewriting PR #548 as I want to do a bunch of that differently. I am actively working on it today, but figure that that PR will simply be dropped and replaced by another update. You'll probably have to wait for my update to apply your additional fixes then but they'll basically be approved at that point.
I see. Not sure what additional changes you are referring to. Is this this PR or something else?
I have pushed your changes to master. Thanks.