hyperbole icon indicating copy to clipboard operation
hyperbole copied to clipboard

Add support for org face types to support org 9.7 and older

Open matsl opened this issue 1 year ago • 1 comments

What

Add support for org face types to support org 9.7 and older.

Why

Org 9.7 changes the use of face types in an not compatible way having multiple properties where we in the past only had one. This PR tries to adopt for that.

Note

Filing the PR for feedback at the end of my working day! PTAL

matsl avatar Jun 23 '24 22:06 matsl

Will want a few changes here. I will likely send a PR against this branch tonight for you to look at. Finish any other tests you want on this code and I’ll ensure they continue to work.

Great. This is how far I got yesterday. Looking forward to your comments.

I think there are some edge cases that might not be properly handled that we could add tests for. If possible, point put those and we can write tests for them to ensure it will continue to work over time. I think though current tests could be covering most practical cases.

matsl avatar Jun 24 '24 21:06 matsl