hyperbole
hyperbole copied to clipboard
rswgnu
Quote lambdas used in hact calls
What
Quote lambdas used in hact calls.
Why
The lambda was not passed as a function to hact. Noticed with recent versions of Emacs 30.
approved these changes
Thanks. Maybe I'll look a bit deeper at it first unless you think it is a show stopper now and we should use it as work around?
I pushed an update to handle Emacs 30 closures to the rsw branch.
See if you can fix the failing tests here:
https://github.com/rswgnu/hyperbole/actions/runs/9056493310/job/24879104466?pr=521
On Sun, May 12, 2024 at 11:05 AM Mats Lidell @.***> wrote:
Closed #524 https://github.com/rswgnu/hyperbole/pull/524.
— Reply to this email directly, view it on GitHub https://github.com/rswgnu/hyperbole/pull/524#event-12778825984, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5WPDZQVSXRMA2VQDETFUTZB6AMRAVCNFSM6AAAAABHH4MSW6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG43TQOBSGU4TQNA . You are receiving this because your review was requested.Message ID: @.***>
I pushed an update to handle Emacs 30 closures to the rsw branch. See if you can fix the failing tests here: https://github.com/rswgnu/hyperbole/actions/runs/9056493310/job/24879104466?pr=521
Do you think the test cases needs an update? If so why? They work fine for all other versions and have done that for some time. Or are you saying that you want me to look into what to add to your update so that the test cases pass?
I notice a change in the error though. The test cases now fail due to this (or similar depending on the test case)
(wrong-number-of-arguments #[nil ((call-interactively 'hui:ibut-rename))
It could be due to another Emacs 30 incompatibility change of course. Need to investigate that further to see where it occurs.
Yes, see what you can do to fix the errors and remove any expected fail test cases left in the rsw branch. Thanks.-- BobOn May 13, 2024, at 8:33 AM, Mats Lidell @.***> wrote:
I pushed an update to handle Emacs 30 closures to the rsw branch. See if you can fix the failing tests here: https://github.com/rswgnu/hyperbole/actions/runs/9056493310/job/24879104466?pr=521
Do you think the test cases needs an update? If so why? They work fine for all other versions and have done that for some time. Or are you saying that you want me to look into what to add to your update so that the test cases pass? I notice a change in the error though. The test cases now fail due to this (or similar depending on the test case)
(wrong-number-of-arguments #[nil ((call-interactively 'hui:ibut-rename))
It could be due to another Emacs 30 incompatibility change of course. Need to investigate that further to see where it occurs.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>