rswag icon indicating copy to clipboard operation
rswag copied to clipboard

This line creates a circular dependency

Open kwstannard opened this issue 3 years ago • 3 comments

Hi rswag team,

I ran into an error caused by the circular dependency while trying to extend swagger_formatter to add a leading comment to the swagger.yaml file.

https://github.com/rswag/rswag/blob/8a6ebbef9777ae2d81dfc13f950d41270ebe621f/rswag-specs/lib/rswag/specs/swagger_formatter.rb#L5

The app depends on rswag-specs, but swagger_helper lives in the app which means that rswag-specs depends on the app in turn, creating a circular dependency.

Regards, Kelly

kwstannard avatar May 20 '22 14:05 kwstannard

@kwstannard how do you resolve this issue?

gentaro-sakamoto avatar Aug 03 '22 06:08 gentaro-sakamoto

@kwstannard thanks for the heads up. I've been wrapped up with other issues for the past few months and am now getting back to this project. There's a lot to catch up on, but if you submit a PR I'll do my best to get it merged and released. Otherwise it might be awhile until I get to this :confused:

jtannas avatar Aug 31 '22 03:08 jtannas

@gentaro-sakamoto Looks like I gave up :D

I am also swamped, so idk if I will be opening a PR anytime soon.

kwstannard avatar Sep 01 '22 20:09 kwstannard

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If the issue is still relevant to you, please leave a comment stating so to keep the issue from being closed. Thank you for your contributions.

stale[bot] avatar Mar 18 '24 02:03 stale[bot]