rsuite icon indicating copy to clipboard operation
rsuite copied to clipboard

chore: remove babel-plugin-lodash

Open simonguo opened this issue 1 year ago • 4 comments

This pull request focuses on removing the lodash library and its related plugins from the project, as well as updating import statements to use specific lodash functions. Additionally, it includes a minor change to an ESLint directive in the webpack.config.js file.

Removal of lodash and related plugins:

  • babel.config.js: Removed the 'lodash' plugin from the Babel plugins list.
  • package.json: Removed babel-plugin-lodash and lodash-webpack-plugin from the dependencies. [1] [2]
  • webpack.config.js: Removed LodashModuleReplacementPlugin and its configuration.

Update of lodash import statements:

  • src/CheckTree/utils.ts: Changed import statements to import specific lodash functions (isNil, isUndefined).
  • src/CheckTreePicker/CheckTreePicker.tsx: Changed import statements to import specific lodash functions (isNil, pick, isFunction, omit).

ESLint directive update:

  • webpack.config.js: Updated ESLint directive to use @typescript-eslint/no-require-imports instead of @typescript-eslint/no-var-requires.

simonguo avatar Jan 03 '25 08:01 simonguo

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar Jan 03 '25 08:01 codesandbox[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 9:10am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 9:10am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 9:10am

vercel[bot] avatar Jan 03 '25 08:01 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jan 03 '25 08:01 codesandbox-ci[bot]

Codecov Report

:x: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 89.51%. Comparing base (cf160fe) to head (e6a2e58). :warning: Report is 236 commits behind head on next.

Files with missing lines Patch % Lines
src/MaskedInput/test/adjustCaretPositionSpec.ts 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #4107   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files         520      520           
  Lines       12381    12381           
  Branches     3180     3180           
=======================================
  Hits        11083    11083           
  Misses        635      635           
  Partials      663      663           
Flag Coverage Δ
ChromeCi 75.44% <91.66%> (ø)
Firefox 89.49% <91.66%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 03 '25 08:01 codecov[bot]